19:00:14 <wumpus> #startmeeting
19:00:14 <lightningbot> Meeting started Thu Apr 25 19:00:14 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:14 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00:23 <jonasschnelli> hi
19:00:37 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
19:00:49 <jamesob> hi
19:00:52 <sdaftuar> hi
19:00:55 <luke-jr> hi
19:01:07 <sipa> half here; will be there in 5-10 min
19:01:10 <wumpus> one topic was proposed in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a, anything else?
19:02:00 <wumpus> #topic high priority for review
19:02:29 <wumpus> 6 PRs on the list: https://github.com/bitcoin/bitcoin/projects/8
19:02:47 <jamesob> can I get #15849 added? the change has been hanging out for a while, is generally useful, and I'd like it builtin for some work I'm doing on scheduler locks
19:02:49 <gribble> https://github.com/bitcoin/bitcoin/issues/15849 | Thread names in logs and deadlock debug tools by jamesob · Pull Request #15849 · bitcoin/bitcoin · GitHub
19:02:49 <wumpus> anything to add/remove?
19:03:19 <wumpus> jamesob:sure, added
19:03:24 <jamesob> thanks!
19:03:24 <phantomcircuit> wumpus, iirc the issue with nat-pmp was the quality of the upstream library more so than it's unmaintained status
19:03:37 <wumpus> phantomcircuit: ok
19:05:05 <wumpus> #topic 0.18.0-final early next week? (MarcoFalke)
19:05:49 <instagibbs> hi
19:05:50 <wumpus> seems a no-brainer, if no new regressions or critical issues come up, then -final will be tagged one week from last rc (which was monday)
19:06:19 <achow101> ack
19:07:07 <jnewbery> hi
19:08:57 <wumpus> there's #15665, if someone manages to reproduce it in detail to make a fix it'd make sense to do a rc5, but I don't think it's bad enough to block the release completely
19:08:58 <gribble> https://github.com/bitcoin/bitcoin/issues/15665 | 0.18.0 rc2 CPU spike in thread bitcoin-opencon · Issue #15665 · bitcoin/bitcoin · GitHub
19:09:22 <cfields> wumpus: fyi, I'll be away until Tues, so there may be a little delay in the win sig.
19:09:41 <jnewbery> I feel like #15141 could be close to ready. If sipa, aj or bluematt could look at it again, I think it may be ready for merge
19:09:43 <wumpus> cfields: no problem
19:09:45 <gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
19:09:58 <wumpus> jnewbery: how does this relate to 0.18.0?
19:10:39 <jnewbery> oh sorry, missed that we'd moved on from #highpriority
19:10:51 <jnewbery> not related to 0.18
19:11:04 <wumpus> jnewbery: oh! makes sense
19:11:45 <wumpus> good to know it's almost ready
19:12:41 <sipa> here
19:12:44 <wumpus> any other topics?
19:12:53 <kanzure> hi
19:13:07 <instagibbs> micro-topic, did sipa or anyone email dev list about segwit v1+ output relay
19:13:19 <instagibbs> sorry if I missed it, I just think it's polite to announce it early
19:13:27 <sipa> i didn't
19:13:34 <wumpus> #topic segwit v1+ output relay announcement
19:14:21 <sdaftuar> that seems like a strange thing to announce imo?  but fine of course if someone feels like it
19:14:46 <instagibbs> why?
19:14:58 <sdaftuar> if it has any impact on the network today then that seems bad!
19:15:14 <instagibbs> it might on wonky wallets or in some way we didn't consider :)
19:15:18 <sdaftuar> ie some service is being griefed or something
19:15:29 <sdaftuar> sure, no harm of course
19:15:47 <harding> instagibbs: you mean announce that it fixes wallets that try to send to v1 now but get their transactions rejected by nodes?
19:15:53 <sipa> i think it makes sense to try encourage wallet developers to support sending to future witness versions... and to the extent that a relay policy change contributes to that it's a good thing
19:16:05 <instagibbs> sipa, that too!
19:16:17 <luke-jr> seems like it belongs just in release notes, but who knows who reads those
19:16:17 <sipa> but it is not actually making any observable change to the network now
19:16:20 <sdaftuar> sipa: i agree with that, i just worry that pointing out that v1 relay currently doesn't work might have the opposite effect
19:16:26 <sipa> sdaftuar: ha
19:16:38 * sipa looks at harding for opinions
19:17:10 <instagibbs> Policy has been changed in the past and end-users(people building on top) end up quite surprised, ive seen it multiple times
19:17:18 <instagibbs> anyways, end of topic i guess
19:17:31 <moneyball> we could announce in optech newsletter?
19:17:36 <harding> I'm also worried that announcing that v1 doesn't work will cause wallet authors to disable it.  I actually wrote docs suggesting that (not published) a couple weeks ago because that's what it looked like Bitcoin Core was encouraging.
19:18:28 <sipa> small topic: what is the status of the getdata randomization? i know it was reverted for 0.18, but for master it seems there were multiple solutions
19:19:18 <wumpus> #topic status of getdata randomization
19:19:32 <sdaftuar> sipa: i've got a PR in progress to fix the issues, working on a test as well (that's what's holding me up from updating the pr)
19:19:54 <luke-jr> :x
19:20:00 <sdaftuar> i guess he didn't like that answer
19:20:14 <sdaftuar> #15834, in case anyone is curious
19:20:17 <gribble> https://github.com/bitcoin/bitcoin/issues/15834 | Fix NOTFOUND bug and expire getdata requests for transactions by sdaftuar · Pull Request #15834 · bitcoin/bitcoin · GitHub
19:21:30 <sipa> i have returned
19:21:34 <wumpus> woohoo !
19:21:40 <sipa> 12:19:32 < sdaftuar> sipa: i've got a PR in progress to fix the issues, working on a test as well (that's what's holding me up from updating the pr)
19:21:45 <sipa> is the last i saw
19:22:00 <luke-jr> right after that [19:19:40] <-- sipa (~pw@gateway/tor-sasl/sipa1024) has left this server (Remote host closed the connection).
19:22:07 <wumpus> sdaftuar | i guess he didn't like that answer
19:22:13 <wumpus> sdaftuar | #15834, in case anyone is curious
19:22:16 <gribble> https://github.com/bitcoin/bitcoin/issues/15834 | Fix NOTFOUND bug and expire getdata requests for transactions by sdaftuar · Pull Request #15834 · bitcoin/bitcoin · GitHub
19:22:21 <wumpus> (and then gribble) that's all
19:22:21 <sipa> ok, thanks
19:23:30 <wumpus> any other topics ?
19:25:52 <wumpus> looks like no - short meeting this time
19:25:55 <wumpus> #endmeeting