19:00:29 <wumpus> #startmeeting
19:00:29 <lightningbot> Meeting started Thu Sep 12 19:00:29 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:29 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00:47 <jonasschnelli> hi
19:00:48 <achow101> hi
19:00:48 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
19:00:53 <dongcarl> jonasschnelli: nice
19:00:54 <meshcollider> hi
19:00:54 <instagibbs> hi
19:00:59 <sipa> hi
19:01:13 <jtimon> hi
19:01:47 <jamesob> hi
19:01:49 <wumpus> one proposed topic in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a: p2p pr dashboard (aj)
19:02:41 <wumpus> #topic High priority for review
19:02:54 <BlueMatt> also should discuss #15584
19:02:57 <gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub
19:03:18 <wumpus> in three days there's the feature freeze for 0.19
19:03:54 <wumpus> are there any feature PRs that could still make it?
19:04:27 <wumpus> doesn't seem to be any in the current list: https://github.com/bitcoin/bitcoin/projects/8
19:04:57 <BlueMatt> 15584 may imply eg #16852
19:04:59 <gribble> https://github.com/bitcoin/bitcoin/issues/16852 | gui: When BIP70 is disabled, get PaymentRequest merchant using string search by achow101 · Pull Request #16852 · bitcoin/bitcoin · GitHub
19:05:02 <BlueMatt> which could be a feature
19:05:09 <achow101> #16512?
19:05:12 <gribble> https://github.com/bitcoin/bitcoin/issues/16512 | Shuffle inputs and outputs after joining psbts by achow101 · Pull Request #16512 · bitcoin/bitcoin · GitHub
19:05:16 <achow101> (could be a feature, or a bug)
19:05:39 <BlueMatt> also I know sdaftuar wanted to land #16851, though that may be challenging
19:05:41 <gribble> https://github.com/bitcoin/bitcoin/issues/16851 | Continue relaying transactions after they expire from mapRelay by ajtowns · Pull Request #16851 · bitcoin/bitcoin · GitHub
19:06:48 <wumpus> #15204 also seems unlikely to make it
19:06:50 <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
19:07:05 <wumpus> (is tagged 0.19)
19:07:43 <meshcollider> Yeah it hasn't had much review, it could make it if people wanted to review it today/tomorrow
19:07:45 <wumpus> not sure #16852 can really be considered a feature, maybe
19:07:47 <gribble> https://github.com/bitcoin/bitcoin/issues/16852 | gui: When BIP70 is disabled, get PaymentRequest merchant using string search by achow101 · Pull Request #16852 · bitcoin/bitcoin · GitHub
19:08:30 <wumpus> I'd be fine with merging that after the feature freeze at least
19:09:28 <wumpus> adding #16851 to high prio, who knows it can still make it
19:09:30 <gribble> https://github.com/bitcoin/bitcoin/issues/16851 | Continue relaying transactions after they expire from mapRelay by ajtowns · Pull Request #16851 · bitcoin/bitcoin · GitHub
19:10:30 <wumpus> #topic p2p PR dashboard (aj)
19:10:44 <aj> hey
19:11:15 <wumpus> link: https://gist.github.com/ajtowns/6073bd110b9f3193293b4321ce8a0394
19:11:31 <aj> thanks. so that has some notes and a link to a test board i setup
19:11:51 <aj> idea is to give an overview of the p2p related PRs so it's easier to find something to review
19:12:13 <aj> the script there seems to be working so far at picking up changes
19:12:47 <wumpus> should probably replace https://github.com/bitcoin/bitcoin/projects/4
19:13:28 <meshcollider> is triage permission sufficient to edit projects?
19:13:32 <aj> i'm thinking we can try this as a project for a little while and maybe if it turns out to be useful maybe it will eventually be worth making labels map to columns better or similar
19:13:53 <aj> i couldn't tell what permissions were needed for projects by looking at the docs
19:14:01 <wumpus> meshcollider: good question, I don't really know
19:14:21 <sipa> i believe it isn't
19:14:33 <sipa> or at least it wasn't a while ago
19:14:34 <dongcarl> I believe I have triage permission... And I can add things to projects...
19:15:08 <sipa> dongcarl: no i reverted your triage permission back to what it was before after you complained your couldn't edit projects anymore
19:15:28 <dongcarl> sipa: Oh cool. Had forgotten
19:15:57 <wumpus> that makes it significantly less useful than using labels
19:16:08 <meshcollider> concept ack adding aj to the issue management team then?
19:16:17 <wumpus> oh, fine with me
19:16:30 <aj> i think you can have organization level projects and have more fine grained permissions there fwiw
19:16:35 <sipa> dongcarl: let's test; can you still edit projects now?
19:16:43 <sipa> (i made you triage)
19:17:09 <dongcarl> sipa: nope I cannot
19:17:14 <dongcarl> makes sense
19:17:18 <dongcarl> aj: Would like a "previous attempts" column if possible
19:17:19 <sipa> dongcarl: cool; reverted back
19:17:53 <dongcarl> aj: Lmk when the new project is up, I'll tranfer things over and close the previous one
19:18:21 <wumpus> ok, let's add aj to write access then
19:18:41 <aj> dongcarl: not sure what "previous attempts" would mean? (versus a note in the PR itself eg)
19:18:51 <wumpus> ACK on the idea at least, if you're going to maintain this actively
19:19:12 <aj> wumpus: that's the plan, and the script is working so far
19:19:23 <wumpus> great!
19:19:43 <aj> also, any other ideas about how to separate things welcome, here, email or commenting on the gist all work
19:20:20 <dongcarl> aj: Well I just thought it'd be nice for those who are picking PRs to work on to have an easy view of past attempts at certain refactors/features
19:20:51 <dongcarl> no need to hold up the meeting tho if there are other things to talk about, I can post on gist
19:21:06 <aj> dongcarl: maybe an "upforgrabs" column would make more sense, as in "past attempts that haven't yet been taken up" and you just look at the PR for previous attempts for that particular feature once it's been grabbed?
19:21:39 <aj> ack for chatting out of meeting though
19:21:47 <dongcarl> aj: That's perfect
19:23:14 <wumpus> aj: ok, added you
19:24:03 <wumpus> #topic disable BIP70 support by default for 0.19 (BlueMatt)
19:25:02 <meshcollider> Congrats on 40k GitHub stars btw
19:25:24 <wumpus> same!
19:25:26 <BlueMatt> more a fanquake topic than I
19:25:47 <BlueMatt> but question is whether to do it independant of #16852
19:25:49 <gribble> https://github.com/bitcoin/bitcoin/issues/16852 | gui: When BIP70 is disabled, get PaymentRequest merchant using string search by achow101 · Pull Request #16852 · bitcoin/bitcoin · GitHub
19:26:01 <BlueMatt> imo yes, but would be nice to land both
19:26:20 <wumpus> fanquake isn't here now afaik it's middle of the night down under
19:26:21 <BlueMatt> and mostly lets kill bip70, finally
19:26:23 <jonasschnelli> 16852 needs more review... three days left though
19:26:23 <achow101> There's also #16858
19:26:25 <gribble> https://github.com/bitcoin/bitcoin/issues/16858 | Qt: advise users not to switch wallets when opening a BIP70 URI. by jameshilliard · Pull Request #16858 · bitcoin/bitcoin · GitHub
19:26:41 <wumpus> yes, I'm in favor too
19:26:51 <jonasschnelli> I have plans to merge 16858 (the warning) in 3 days if no objections
19:27:11 <achow101> I think it's fine to disable without 16852. it's really such a small thing that no one will probably notice
19:27:23 <jonasschnelli> I guess its too late for the string search and the complete removal
19:27:40 <BlueMatt> ehh removal by default I'd still love to see in 19 either way
19:28:06 <jonasschnelli> review it!
19:28:10 <meshcollider> Yeah I think it's doable
19:28:17 <BlueMatt> i mean even without 16852
19:28:18 <wumpus> the string search one just needs testing
19:28:29 <wumpus> it certainly could make it in for 0.19
19:28:36 <BlueMatt> but, right, should test 16852
19:28:42 <achow101> to properly review the string search, you probably will want to look at the X.509 and Protobuf specs
19:29:01 <wumpus> the thing is that no one seems to actually have a wallet with payment request in it :)
19:29:11 <BlueMatt> or, at least, an un-expired payment request
19:29:20 <BlueMatt> cause they die after expiry anyway, so it cant be worse lol
19:29:25 <achow101> I've got a few from my own testing
19:29:37 <achow101> I can just like send payment requests to people for testnet
19:30:38 <achow101> i jumped through the hoops to get a bitpay testnet account so I can get these things at will now
19:31:15 <wumpus> hah
19:31:18 <bitcoin-git> [13bitcoin] 15laanwj closed pull request #15064: [PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] (06master...06bip70_merchant_to_to) 02https://github.com/bitcoin/bitcoin/pull/15064
19:31:23 <jonasschnelli> Can't you not just use gavings old php script?
19:31:26 <jonasschnelli> I ues that in the past
19:31:29 <jonasschnelli> *used
19:31:37 <wumpus> does that still work?
19:31:47 <jonasschnelli> I guess the protocol hasn't changed :)
19:32:05 <jonasschnelli> I mean you need to load the script an your own server
19:32:06 <jonasschnelli> https://github.com/gavinandresen/paymentrequest
19:32:15 <wumpus> that's probably the only thing that hasn't changed tho :)
19:32:26 <jonasschnelli> heh
19:33:11 <wumpus> so, anyhow, everyone in favor of disabling BIP70 by default for 0.19?
19:33:16 <achow101> ack
19:33:21 <BlueMatt> seems like it
19:33:22 <sipa> no objection
19:33:22 <jonasschnelli> ack
19:33:23 <meshcollider> +1
19:33:54 <midnightmagic> +1
19:34:00 <warren> +1
19:34:02 <BlueMatt> plz2merge #15584?
19:34:05 <gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub
19:34:05 <wumpus> that's pretty clear
19:34:06 <jb55> +1
19:35:06 <achow101> topic suggestion: changing version numbering scheme to year based
19:35:16 <BlueMatt> jonasschnelli: plz2merge #16858
19:35:18 <gribble> https://github.com/bitcoin/bitcoin/issues/16858 | Qt: advise users not to switch wallets when opening a BIP70 URI. by jameshilliard · Pull Request #16858 · bitcoin/bitcoin · GitHub
19:35:57 <warren> 0.19 would be the 2019 release? =)
19:36:09 <wumpus> #topic changing version numbering scheme to year based (achow101)
19:36:18 <wumpus> meh, I'd prefer to keep it as is
19:36:31 <midnightmagic> Same.
19:36:33 <achow101> it's a good time to change it since it wouldn't really be a major version number change
19:37:02 <BlueMatt> doesn't that get complicated wrt 6-month release cycle?
19:37:04 <wumpus> also didn't pretty much everything switch away from year based versioning?
19:37:14 <BlueMatt> 0.19.month.rev?
19:37:17 <sipa> ubuntu still does, i think?
19:37:18 <BlueMatt> thats...complicated
19:37:33 <wumpus> yeah, ubuntu does...
19:37:36 <achow101> could just do major is year, the rest just count up for the year
19:37:46 <wumpus> but why anyway
19:37:50 <sipa> no strong opinion
19:37:52 <achow101> similar to ubuntu, though they do year.month.rev
19:37:58 <achow101> no strong opinion, literal showerthought
19:38:09 <BlueMatt> sounds like 0 concept acks, so....move on?
19:38:15 <wumpus> yep
19:39:14 <wumpus> any other topics?
19:39:41 <warren> wumpus: what happened with the transifex admin thing?
19:40:09 <warren> wumpus: will language leads happen for reviews?
19:40:12 <wumpus> warren: it was resolved! (they gave me admin for the org)
19:40:39 <warren> I mean what is the next step? your new superpowers could create more opportunity for community to be involved.
19:40:44 <wumpus> warren: feel free to propose people
19:41:03 <warren> wumpus: I'm a mono-linguist!
19:41:14 <warren> anyhow just pointing out it's possible
19:41:58 <wumpus> yes, good to know, so if anyone is interested in getting more involved in translations for some language, let me know please
19:42:22 <warren> not just more involved, but should there be per-language team leads?
19:42:48 <warren> and some loose standards of how it's run alongside the release schedule
19:42:54 <wumpus> if someone  steps up for some language, sure
19:43:04 <wumpus> fine with trying it at least
19:44:03 <warren> move on
19:44:06 <wumpus> gchuf has been helping a bit with sorting out the transifex mess
19:45:54 <wumpus> #endmeeting