19:00:47 <meshcollider> #startmeeting
19:00:47 <lightningbot> Meeting started Fri Nov 22 19:00:47 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:47 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00:51 <achow101> pls merge things. thx
19:00:57 <jonatack> hi
19:01:05 <kanzure> hi
19:01:11 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
19:01:40 <meshcollider> I'm going to merge some PRs today finally
19:01:43 <meshcollider> Topics?
19:01:51 <achow101> finally
19:03:15 <achow101> what metrics does SRD have to meet in order to be merged?
19:03:33 <achow101> see #17526
19:03:34 <gribble> https://github.com/bitcoin/bitcoin/issues/17526 | Use Single Random Draw In addition to knapsack as coin selection fallback by achow101 · Pull Request #17526 · bitcoin/bitcoin · GitHub
19:04:11 <meshcollider> I don't know, acks from coin selection people I guess
19:05:32 <achow101> we kind of got stuck on what "better" meant with the last time we tried this, so I wanted to try to define "better" concretely
19:06:35 <jonatack> not a coin selection person yet, apart from reading murch's work, but started reviewing and testing #17290
19:06:37 <gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 · Pull Request #17290 · bitcoin/bitcoin · GitHub
19:07:06 <bitcoin-git> [13bitcoin] 15meshcollider pushed 3 commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/bb862d7864cc...cef87f7a48f7
19:07:07 <bitcoin-git> 13bitcoin/06master 14db15e71 15Andrew Chow: Use BnB when preset inputs are selected
19:07:07 <bitcoin-git> 13bitcoin/06master 14b007efd 15Andrew Chow: Allow BnB when subtract fee from outputs
19:07:07 <meshcollider> I'm merging that at the moment
19:07:08 <bitcoin-git> 13bitcoin/06master 14cef87f7 15Samuel Dobson: Merge #17290: Enable BnB coin selection for preset inputs and subtract fee...
19:07:16 <achow101> yay
19:07:26 <bitcoin-git> [13bitcoin] 15meshcollider merged pull request #17290: Enable BnB coin selection for preset inputs and subtract fee from outputs (06master...06all-bnb) 02https://github.com/bitcoin/bitcoin/pull/17290
19:07:38 <meshcollider> Post merge ack would be great though when you're done jonatack :)
19:07:51 <jonatack> sure, will learn something :)
19:08:06 <achow101> it might be better to discuss acceptance criteria at the next coredev event? at least that's what we did for BnB to get merged
19:08:16 <meshcollider> Yeah I think so
19:08:17 <achow101> arguing around a whiteboard and all that :p
19:08:35 <meshcollider> We need more discussion around it but it's difficult to attract that discussion
19:08:53 <meshcollider> We can't make all coin selection decisions on the basis of you, instagibbs and provoostenator
19:11:10 <achow101> unfortunately people don't like to touch coin selection
19:11:25 <achow101> including yourself
19:12:08 <meshcollider> At least for me, it's mostly fear of breaking it because it's so unclear what the goals and tradeoffs should be
19:13:36 <meshcollider> No topics?
19:13:49 <meshcollider> I guess yesterday was a short meeting so I'm not surprised today is too
19:13:58 <meshcollider> #endmeeting