12019-11-13T00:00:57  *** arik_ has quit IRC
 22019-11-13T00:10:50  *** Moller40_ has quit IRC
 32019-11-13T00:32:11  *** Chris_Stewart_5 has quit IRC
 42019-11-13T02:02:10  *** Chris_Stewart_5 has joined ##taproot-bip-review
 52019-11-13T02:22:08  *** Chris_Stewart_5 has quit IRC
 62019-11-13T02:27:01  *** Moller40 has joined ##taproot-bip-review
 72019-11-13T06:53:34  *** xoyi- has joined ##taproot-bip-review
 82019-11-13T07:30:08  *** Moller40_ has joined ##taproot-bip-review
 92019-11-13T07:30:50  *** Moller40 has quit IRC
102019-11-13T07:53:05  *** Moller40_ has quit IRC
112019-11-13T07:54:08  *** Moller40 has joined ##taproot-bip-review
122019-11-13T08:16:17  *** Moller40 has quit IRC
132019-11-13T08:18:09  *** Moller40 has joined ##taproot-bip-review
142019-11-13T08:59:34  *** b10c has joined ##taproot-bip-review
152019-11-13T09:22:53  *** Moller40 has quit IRC
162019-11-13T09:24:10  *** Moller40_ has joined ##taproot-bip-review
172019-11-13T10:17:38  *** Moller40_ has quit IRC
182019-11-13T10:18:32  *** Moller40 has joined ##taproot-bip-review
192019-11-13T10:20:08  *** Moller40 has quit IRC
202019-11-13T10:53:41  *** jonatack has quit IRC
212019-11-13T11:04:13  *** orfeas has joined ##taproot-bip-review
222019-11-13T11:48:38  *** Chris_Stewart_5 has joined ##taproot-bip-review
232019-11-13T12:20:45  *** jonatack has joined ##taproot-bip-review
242019-11-13T12:47:48  *** Chris_Stewart_5 has quit IRC
252019-11-13T12:55:04  *** Chris_Stewart_5 has joined ##taproot-bip-review
262019-11-13T13:13:50  *** jonatack has quit IRC
272019-11-13T13:49:56  *** rottensox has joined ##taproot-bip-review
282019-11-13T13:50:03  *** Chris_Stewart_5 has quit IRC
292019-11-13T13:52:38  *** Chris_Stewart_5 has joined ##taproot-bip-review
302019-11-13T14:40:25  *** jonatack has joined ##taproot-bip-review
312019-11-13T14:50:39  *** xoyi- has quit IRC
322019-11-13T15:12:49  *** HighOnBtc has quit IRC
332019-11-13T15:43:16  *** jonatack has quit IRC
342019-11-13T15:58:38  <orfeas> is the name `taproot_sign_script()` a slight abuse of the term "sign"? The sigining algorithm isn't invoked in the function
352019-11-13T15:58:56  <orfeas> an alternative could be `taproot_generate_script_sig()` or similar
362019-11-13T15:59:13  <instagibbs> that would sound like scriptSig, which segwit v1 never touches
372019-11-13T15:59:54  <orfeas> correct
382019-11-13T16:05:59  <orfeas> `taproot_prove_script()` or `taproot_choose_script_path()` then?
392019-11-13T16:07:41  <sipa> orfeas: i think signing is an acceptable term
402019-11-13T16:08:29  <sipa> orfeas: in the sense that you see a scriptPubKey as the public key of the "script" digital signature system, and the scriptSig/witness is the signature for it
412019-11-13T16:12:37  <orfeas> I feel this is a complete redefinition of the terms "public key" and "signature".
422019-11-13T16:13:16  <orfeas> (note that I'm biased: I always found the terms script{PubKey,Sig} somewhat confusing)
432019-11-13T16:14:02  <instagibbs> it was redefined 11 years ago, sorry :P
442019-11-13T16:14:16  <instagibbs> err I guess 10 still
452019-11-13T16:15:49  <orfeas> '=D
462019-11-13T16:16:10  <orfeas> fair enough
472019-11-13T16:23:20  *** jonatack has joined ##taproot-bip-review
482019-11-13T16:33:38  *** andytoshi has joined ##taproot-bip-review
492019-11-13T16:33:38  *** andytoshi has joined ##taproot-bip-review
502019-11-13T17:36:42  *** so has joined ##taproot-bip-review
512019-11-13T17:48:25  <devrandom> trivial wording improvements from yesterday Q&A https://github.com/sipa/bips/pull/144
522019-11-13T18:04:12  *** Chris_Stewart_5 has quit IRC
532019-11-13T18:25:18  *** Chris_Stewart_5 has joined ##taproot-bip-review
542019-11-13T18:36:57  *** HighOnBtc has joined ##taproot-bip-review
552019-11-13T20:12:34  *** xoyi- has joined ##taproot-bip-review
562019-11-13T20:13:42  *** Chris_Stewart_5 has quit IRC
572019-11-13T20:17:17  *** HighOnBtc has quit IRC
582019-11-13T20:17:28  *** Chris_Stewart_5 has joined ##taproot-bip-review
592019-11-13T20:31:49  *** xoyi- has quit IRC
602019-11-13T20:45:32  *** rottensox has quit IRC
612019-11-13T20:45:47  *** rottensox has joined ##taproot-bip-review
622019-11-13T20:58:06  *** Chris_Stewart_5 has quit IRC
632019-11-13T20:59:20  *** b10c has quit IRC
642019-11-13T21:05:51  *** Chris_Stewart_5 has joined ##taproot-bip-review
652019-11-13T21:15:00  *** orfeas has quit IRC
662019-11-13T22:00:32  <pinheadmz> sipa: is a witness with an annex non-standard?
672019-11-13T22:00:33  <pinheadmz> https://github.com/sipa/bitcoin/blob/taproot/test/functional/feature_taproot.py#L390
682019-11-13T22:18:25  *** b10c has joined ##taproot-bip-review
692019-11-13T22:34:51  <instagibbs> pinheadmz, look at `IsWitnessStandard` definition in the taproot branch, doesn't appear to be non-standard
702019-11-13T22:35:10  <instagibbs> could be reading it wrong of course, but it's covered by the sighash, so it's not malleable by third party
712019-11-13T22:56:20  <andytoshi> pinheadmz: sipa tells me "yes absolutely. any annex at all is currently nonstandard"
722019-11-13T22:56:30  <andytoshi> but he is driving rn and cannot respond himself
732019-11-13T22:58:38  <pinheadmz> andytoshi: ha! thank you for relaying, and for driving safely!
742019-11-13T22:59:17  <instagibbs> I'd appreciate a pointer in the reference code, I am apparently blind
752019-11-13T22:59:41  <pinheadmz> instagibbs: link ^^
762019-11-13T22:59:47  <pinheadmz> I was looking at the pyhton test
772019-11-13T23:00:09  <instagibbs> reference implementation meaning the C++ logic which makes it non-standard
782019-11-13T23:00:41  <pinheadmz> id have to look, just saw this line in the test
792019-11-13T23:00:42  <pinheadmz> https://github.com/sipa/bitcoin/blob/taproot/test/functional/feature_taproot.py#L390
802019-11-13T23:00:53  <pinheadmz> and didnt see anything calling annexes non-std in the bip
812019-11-13T23:01:05  <instagibbs> standardness isn't generally BIP material
822019-11-13T23:01:13  <andytoshi> heh i can take a look
832019-11-13T23:01:13  <andytoshi> but i won't know better than ou
842019-11-13T23:01:37  <pinheadmz> instagibbs: oh really? We wouldn't want to mention it?
852019-11-13T23:02:05  <andytoshi> because it's a Core implementation detail, arguably
862019-11-13T23:02:28  <andytoshi> (well, this is a very idealized view of standardness)
872019-11-13T23:02:28  <pinheadmz> yeah and if I'm not mistaken, has no defined function (yet)
882019-11-13T23:04:45  <pinheadmz> Does CLEANSTACK apply to the witness stack? Is that where the annex becomes non-std?
892019-11-13T23:06:20  <andytoshi> pinheadmz: no, it's explicit :)
902019-11-13T23:06:29  <andytoshi> pieter says there is a VERIFY flag for it
912019-11-13T23:06:38  <andytoshi> that you should be able to grep for
922019-11-13T23:10:28  <pinheadmz> Can he remember the line number without taking his eyes off the road? X-D
932019-11-13T23:12:05  <pinheadmz> here we go
942019-11-13T23:12:06  <pinheadmz> https://github.com/sipa/bitcoin/blob/taproot/src/policy/policy.h#L76
952019-11-13T23:12:10  <pinheadmz> SCRIPT_VERIFY_DISCOURAGE_UNKNOWN_ANNEX
962019-11-13T23:12:34  <andytoshi> lol that's the one
972019-11-13T23:13:50  *** pinheadmz has quit IRC
982019-11-13T23:29:38  *** b10c has quit IRC
992019-11-13T23:40:50  *** Chris_Stewart_5 has quit IRC