12019-11-27T00:28:28 *** arik_ has quit IRC
22019-11-27T00:40:44 *** Chris_Stewart_5 has joined ##taproot-bip-review
32019-11-27T00:57:31 *** devrando1 has quit IRC
42019-11-27T00:58:11 *** arik_ has joined ##taproot-bip-review
52019-11-27T01:03:32 *** arik_ has quit IRC
62019-11-27T01:20:24 *** Chris_Stewart_5 has quit IRC
72019-11-27T01:20:40 *** arik_ has joined ##taproot-bip-review
82019-11-27T01:28:07 *** arik_ has quit IRC
92019-11-27T01:41:30 *** dongcarl has quit IRC
102019-11-27T02:18:10 *** devrando1 has joined ##taproot-bip-review
112019-11-27T02:21:30 *** Tibo has joined ##taproot-bip-review
122019-11-27T02:43:07 *** devrando1 has quit IRC
132019-11-27T02:51:42 *** pinheadmz has quit IRC
142019-11-27T04:29:53 *** pinheadmz has joined ##taproot-bip-review
152019-11-27T05:50:45 *** rottensox_ has joined ##taproot-bip-review
162019-11-27T05:53:26 *** rottensox has quit IRC
172019-11-27T05:58:07 *** kabaum has quit IRC
182019-11-27T07:00:32 *** kabaum has joined ##taproot-bip-review
192019-11-27T07:01:44 *** Tibo has quit IRC
202019-11-27T07:15:36 *** arik_ has joined ##taproot-bip-review
212019-11-27T07:24:47 *** arik_ has quit IRC
222019-11-27T07:25:31 *** arik_ has joined ##taproot-bip-review
232019-11-27T07:34:07 *** arik_ has quit IRC
242019-11-27T07:55:51 *** arik_ has joined ##taproot-bip-review
252019-11-27T07:59:32 *** jonatack has quit IRC
262019-11-27T08:04:54 *** arik_ has quit IRC
272019-11-27T08:06:20 *** arik_ has joined ##taproot-bip-review
282019-11-27T08:35:29 *** arik_ has quit IRC
292019-11-27T08:36:48 *** kabaum has quit IRC
302019-11-27T08:42:26 *** arik_ has joined ##taproot-bip-review
312019-11-27T08:51:34 *** b10c has joined ##taproot-bip-review
322019-11-27T08:51:47 *** arik_ has quit IRC
332019-11-27T08:52:08 *** davterra has quit IRC
342019-11-27T08:52:33 *** davterra has joined ##taproot-bip-review
352019-11-27T08:52:47 *** arik_ has joined ##taproot-bip-review
362019-11-27T08:55:07 *** jonatack has joined ##taproot-bip-review
372019-11-27T09:07:41 *** arik_ has quit IRC
382019-11-27T09:16:00 *** arik_ has joined ##taproot-bip-review
392019-11-27T09:24:57 *** arik_ has quit IRC
402019-11-27T09:26:10 *** arik_ has joined ##taproot-bip-review
412019-11-27T09:27:33 *** evoskuil[m] has quit IRC
422019-11-27T09:38:11 *** kabaum has joined ##taproot-bip-review
432019-11-27T10:17:43 *** evoskuil[m] has joined ##taproot-bip-review
442019-11-27T10:38:40 *** dr_orlovsky has quit IRC
452019-11-27T10:42:24 *** arik_ has quit IRC
462019-11-27T10:45:35 *** arik_ has joined ##taproot-bip-review
472019-11-27T11:09:02 *** arik_ has quit IRC
482019-11-27T11:11:26 *** arik_ has joined ##taproot-bip-review
492019-11-27T11:40:21 *** arik_ has quit IRC
502019-11-27T11:48:22 *** Chris_Stewart_5 has joined ##taproot-bip-review
512019-11-27T11:55:03 *** dr-orlovsky has joined ##taproot-bip-review
522019-11-27T11:58:55 *** arik_ has joined ##taproot-bip-review
532019-11-27T12:36:17 *** Chris_Stewart_5 has quit IRC
542019-11-27T13:02:03 *** Chris_Stewart_5 has joined ##taproot-bip-review
552019-11-27T13:08:43 *** jonatack has quit IRC
562019-11-27T13:16:00 *** arik_ has quit IRC
572019-11-27T13:43:00 *** jonatack has joined ##taproot-bip-review
582019-11-27T13:57:16 *** rottensox__ has joined ##taproot-bip-review
592019-11-27T13:59:59 *** rottensox_ has quit IRC
602019-11-27T14:02:10 <instagibbs_> fun fact from roconnor: even with gigameg blocks codeseparator_position still cannot overflow because of the MAX_SIZE constant for serialization
612019-11-27T14:02:32 *** rottensox__ has quit IRC
622019-11-27T14:05:59 <gmaxwell> assuming that you haven't increased MAX_SIZE
632019-11-27T14:06:06 <instagibbs_> yeah it's 2 implicit bounds...
642019-11-27T14:06:11 <gmaxwell> or bypassed it for compact_size.
652019-11-27T14:06:13 <instagibbs_> related email https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-June/017056.html
662019-11-27T14:06:27 <instagibbs_> (missed this email thread first time)
672019-11-27T14:25:02 *** devrando1 has joined ##taproot-bip-review
682019-11-27T14:25:04 *** jonatack has quit IRC
692019-11-27T14:25:24 *** jonatack has joined ##taproot-bip-review
702019-11-27T14:27:13 *** jonatack has quit IRC
712019-11-27T15:09:41 *** Chris_Stewart_5 has quit IRC
722019-11-27T15:15:58 *** jonatack has joined ##taproot-bip-review
732019-11-27T15:46:57 *** kabaum has quit IRC
742019-11-27T16:14:36 *** andytoshi has joined ##taproot-bip-review
752019-11-27T16:14:36 *** andytoshi has joined ##taproot-bip-review
762019-11-27T16:40:15 *** pyskell has joined ##taproot-bip-review
772019-11-27T16:40:15 *** pyskell has joined ##taproot-bip-review
782019-11-27T16:41:54 *** pyskell has joined ##taproot-bip-review
792019-11-27T17:01:29 <andytoshi> i kinda wish the taproot bip would have a newline after every sentence so that github could render the diffs properly
802019-11-27T17:06:23 <gmaxwell> I wish github's diffs were as good as mediawiki's.
812019-11-27T17:07:12 <sipa> git diff --word-diff
822019-11-27T17:08:38 <andytoshi> yes, you can pull locally and use real tools
832019-11-27T17:08:52 <andytoshi> but that is roughly 50 times as much work as clicking "diff" on github
842019-11-27T17:09:24 <sipa> yeah
852019-11-27T17:09:36 <sipa> i also only do it for reviewing bigger things
862019-11-27T17:09:54 <andytoshi> for code you generally have to pull anyway to compile-test, run valgrind, etc
872019-11-27T17:22:21 *** rottensox has joined ##taproot-bip-review
882019-11-27T17:29:12 *** michaelfolkson has joined ##taproot-bip-review
892019-11-27T17:31:01 *** rottensox_ has joined ##taproot-bip-review
902019-11-27T17:33:17 *** rottensox has quit IRC
912019-11-27T17:37:10 *** rottensox_ has quit IRC
922019-11-27T17:43:36 *** shesek has quit IRC
932019-11-27T17:43:55 *** devrando1 has quit IRC
942019-11-27T17:43:59 *** shesek has joined ##taproot-bip-review
952019-11-27T17:43:59 *** shesek has joined ##taproot-bip-review
962019-11-27T17:55:43 *** instagibbs_ has quit IRC
972019-11-27T17:56:28 *** instagibbs has joined ##taproot-bip-review
982019-11-27T18:00:03 *** luke-jr has quit IRC
992019-11-27T18:01:11 *** luke-jr has joined ##taproot-bip-review
1002019-11-27T18:08:48 *** rottensox has joined ##taproot-bip-review
1012019-11-27T18:22:35 *** meshcollider has quit IRC
1022019-11-27T18:22:50 *** meshcollider has joined ##taproot-bip-review
1032019-11-27T18:23:28 *** ariard_ has quit IRC
1042019-11-27T18:24:54 *** ariard has joined ##taproot-bip-review
1052019-11-27T18:36:53 *** shesek has quit IRC
1062019-11-27T18:47:15 *** vernon99995 has joined ##taproot-bip-review
1072019-11-27T19:13:51 *** potatoe_face has joined ##taproot-bip-review
1082019-11-27T19:16:44 *** rottensox has quit IRC
1092019-11-27T19:30:06 *** arik_ has joined ##taproot-bip-review
1102019-11-27T19:37:16 *** arik_ has quit IRC
1112019-11-27T19:54:36 *** rottensox has joined ##taproot-bip-review
1122019-11-27T20:00:45 *** michaelfolkson has quit IRC
1132019-11-27T20:03:19 *** michaelfolkson has joined ##taproot-bip-review
1142019-11-27T20:04:19 *** michaelfolkson has quit IRC
1152019-11-27T20:10:47 *** jonatack has quit IRC
1162019-11-27T20:23:29 *** michaelfolkson has joined ##taproot-bip-review
1172019-11-27T20:25:30 *** kabaum has joined ##taproot-bip-review
1182019-11-27T20:33:54 *** kabaum has quit IRC
1192019-11-27T20:34:48 *** michaelfolkson has quit IRC
1202019-11-27T20:35:04 *** kabaum has joined ##taproot-bip-review
1212019-11-27T20:38:51 *** vernon99995 has quit IRC
1222019-11-27T20:42:08 *** kabaum has quit IRC
1232019-11-27T21:46:42 *** pyskell has quit IRC
1242019-11-27T22:04:40 *** dr-orlovsky has quit IRC
1252019-11-27T22:05:20 *** dr-orlovsky has joined ##taproot-bip-review
1262019-11-27T22:16:34 *** jonatack has joined ##taproot-bip-review
1272019-11-27T22:35:37 <aj> andytoshi: having "fetch = +refs/pull/*/head:refs/pull/origin/*" in .git/config makes pulling locally and using real tools pretty easy though?
1282019-11-27T22:56:17 *** shesek has joined ##taproot-bip-review
1292019-11-27T22:56:17 *** shesek has joined ##taproot-bip-review
1302019-11-27T23:13:15 *** andytoshi has quit IRC
1312019-11-27T23:20:56 *** mryandao has quit IRC
1322019-11-27T23:21:02 *** mryandao_ has joined ##taproot-bip-review
1332019-11-27T23:24:17 <gmaxwell> aj: but it doesn't make commenting easy.
1342019-11-27T23:30:41 *** b10c has quit IRC
1352019-11-27T23:53:28 *** michaelfolkson has joined ##taproot-bip-review
1362019-11-27T23:53:49 <aj> gmaxwell: i had a go at writing a script that'd convert a text file of comments on a diff into a github review, but the api didn't seem to work as advertised :-/